-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT FE] Improved MaxPool convert by PyTorch FE #18965
Merged
praasz
merged 5 commits into
openvinotoolkit:master
from
praasz:pytorch-wrong-output-shapes-of-max-pool
Aug 4, 2023
Merged
[PT FE] Improved MaxPool convert by PyTorch FE #18965
praasz
merged 5 commits into
openvinotoolkit:master
from
praasz:pytorch-wrong-output-shapes-of-max-pool
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praasz
changed the title
Improved MaxPool convert by PyTorch FE
[PT FE] Improved MaxPool convert by PyTorch FE
Aug 3, 2023
3 tasks
mmikolajcz
approved these changes
Aug 3, 2023
mvafin
requested changes
Aug 4, 2023
Co-authored-by: Maxim Vafin <[email protected]>
Co-authored-by: Maxim Vafin <[email protected]>
mvafin
approved these changes
Aug 4, 2023
1 task
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
MaxPool
operator byPyTorch
frontend, when sliding windows go off bound.Example:
input shape: [1,3,5,5], kernel=2, stride=2, pad=1,dilation=1, ceil_mode
PyTorch
result shape [1,3,3,3]OV
result shape after conversion [1,3,4,4]This change makes conversion to be aligned with
PyTorch
result.Tickets: