Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT FE] Improved MaxPool convert by PyTorch FE #18965

Merged

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Aug 3, 2023

Details:

  • Improved conversion of MaxPool operator by PyTorch frontend, when sliding windows go off bound.
    Example:
    input shape: [1,3,5,5], kernel=2, stride=2, pad=1,dilation=1, ceil_mode
    • PyTorch result shape [1,3,3,3]
    • OV result shape after conversion [1,3,4,4]
      This change makes conversion to be aligned with PyTorch result.

Tickets:

@praasz praasz requested review from mvafin and mmikolajcz August 3, 2023 10:34
@praasz praasz requested a review from a team as a code owner August 3, 2023 10:34
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Aug 3, 2023
@praasz praasz changed the title Improved MaxPool convert by PyTorch FE [PT FE] Improved MaxPool convert by PyTorch FE Aug 3, 2023
@praasz praasz mentioned this pull request Aug 3, 2023
3 tasks
src/frontends/pytorch/src/op/max_poolnd.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/op/max_poolnd.cpp Outdated Show resolved Hide resolved
@praasz praasz requested a review from mvafin August 4, 2023 12:20
@praasz praasz enabled auto-merge (squash) August 4, 2023 13:20
@praasz praasz merged commit 2385c27 into openvinotoolkit:master Aug 4, 2023
@praasz praasz deleted the pytorch-wrong-output-shapes-of-max-pool branch August 21, 2023 08:52
@ilya-lavrenov ilya-lavrenov linked an issue Sep 16, 2023 that may be closed by this pull request
1 task
@ilya-lavrenov ilya-lavrenov linked an issue Sep 16, 2023 that may be closed by this pull request
3 tasks
@ilya-lavrenov ilya-lavrenov added this to the 2023.1 milestone Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong output shapes of MaxPool
4 participants